Skip to content

refactor pysift as a library with install #17

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

normanb
Copy link

@normanb normanb commented Sep 3, 2020

@rmislam As I was working through the code I refactored the library slightly and added a packaging script (setup.py). If you are interested in this PR then I can expand further and add tox for testing as well as refactoring the code a little to include more testing and modularity.

Thank you for writing this and the excellent tutorial on the SIFT algorithm.

@rmislam
Copy link
Owner

rmislam commented Sep 8, 2020

@normanb Wow, thanks a lot! This is extremely helpful. Yes, I'm very interested in this PR, and please by all means expand further. Truth be told, I don't have too much time these days, but if I can help you out somehow, please let me know.

@normanb
Copy link
Author

normanb commented Sep 9, 2020

@rmislam thank you. I am going to make the library callable by breaking out the functions where I can and so that the code can be ran in parallel to increase performance. I can work in this branch with separate commits so you can clearly see the changes. I understand that the code needs to be readable enough for people following your tutorial.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants