adding timezonr functionality for each schedule job #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robersonfaria
approved these changes
Oct 27, 2022
|
@link2arslan Tests are still broken, can you see the results in the link below? |
|
I have updated a code.
But i have a concerns recording to recreate database in unit test. Because
i have created one column in schedule table and also created a migration
for it.
Please check this database issue. Beacuae it doesn't created the column
with my migration file.
Thanks & Regards
…On Fri, 28 Oct 2022, 5:31 pm Roberson Faria, ***@***.***> wrote:
@link2arslan <https://github.com/link2arslan> Tests are still broken, can
you see the results in the link below?
https://github.com/robersonfaria/laravel-database-schedule/actions/runs/3345322510/jobs/5540917071
—
Reply to this email directly, view it on GitHub
<#56 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARAPS7PIG3LSZGZEUQTXQ63WFPBR3ANCNFSM6AAAAAARO6SF4Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality of timezone for each schedular job. Now users can add a timezone against each job when creating from UI.