update function build_dataset_iteratively to reflect taking start symbol and end symbol for range download #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bol and end symbol as a range for download symbols
|
sorry Robert, I accidentally "commit -a -m" to include the stock csv, and I only have another hour to play on GitHub today, so I did not revert my change and redo them again, please feel free to only modify the change on your function and abandon the PR. Great work by the way! |
|
@GuangMo My apologies for the late response – I will review the modifications and try to merge them some time this coming week |
|
@GuangMo I have reviewed it – I understand what you are trying to do, but I think this should be a new function rather than overwriting the current one |
|
Sounds good, Robert! I will leave it up to you then :)
…Sent from my iPhone
On Mar 14, 2019, at 9:43 AM, Robert Martin ***@***.***> wrote:
@GuangMo I have reviewed it – I understand what you are trying to do, but I think this should be a new function rather than overwriting the current one
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.