remove concurrent avoiding modification member variables (Python) #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exact same changes from wpilibsuite/allwpilib#6593
|
/format |
|
You're welcome to implement a /format bot (#63) but one does not currently exist. |
|
Whenever this gets merged to allwpilib, we're going to want tests here too. |
|
Just for the history, a subset of the PR has been merged should I write tests ASAP or wait until the bigger PR with the Java changes gets merged |
|
It's going to need tests before we merge it, so whenever you have time to do it seems like the right time to do it. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after wpilibsuite/allwpilib#6593