Add Docs Expo Integration (expo-sqlite & op-sqlite) #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3 tasks
|
LGTM |
austinm911
changed the title
arv
approved these changes
Feb 25, 2025
| [userId, authToken], | ||
| ); | ||
|
|
||
| if (!z) { |
There was a problem hiding this comment.
good point - on the other hand do you want this to be simplified and exclude using the useMemo in the docs (but we can keep the comment about in production it should be memoized). Elsewhere in the docs it is kept simple.
| href: string; | ||
| noLink?: true; | ||
| items?: EachRoute[]; | ||
| title: string; |
There was a problem hiding this comment.
formatting change seems a bit odd.
maybe run npm run format
|
@aboodman - do we want to go ahead and merge this? Looks like it got stuck because the formatting of |
|
I was planning to look at this in deeper details (maybe next week or after the vacation end of the month) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rocicorp/mono#3841