[RFC] [cmake] Add core/base headers to target HEADERS file_set #18419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results2 681 tests 2 681 ✅ 4h 38m 33s ⏱️ Results for commit 347cde1. ♻️ This comment has been updated with latest results. |
|
Also potentially related: #17607 |
ferdymercury
commented
Apr 22, 2025
ferdymercury
commented
Apr 22, 2025
ferdymercury
force-pushed
the
cmakefileset
branch
from
e9a87ee to
347cde1
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Gives a taste on how it would look like to properly add HEADERS to targets in CMake.
This does not just help with the IDE workflow, it gives an idea on future paths:
One could make them PUBLIC instead of PRIVATE, then you would not need the target_include_directories line, and installing and cpacking would be easier.
Related:
Checklist:
This PR fixes #