Initial changes for different snapshot behaviours in distRDF #18422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Made 3 new functions within the class, `_get_base_filename`, `_merge_snapshot_files`, `_cleanup_partial_files` 2. added a default option for merging the files -> `MERGE_OUTPUT`
bindings/experimental/distrdf/python/DistRDF/PythonMergeables.py
Outdated
Show resolved
Hide resolved
Test Results 17 files 17 suites 4d 0h 36m 17s ⏱️ For more details on these failures, see this check. Results for commit 4da07ce. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Allows different snapshot behaviours in dist RDF
Changes or fixes:
_get_base_filename,_merge_snapshot_files,_cleanup_partial_filesMERGE_OUTPUTChecklist:
This PR fixes #17136