[gui] Some fixes to TGNumberEntry #18435
Open
+90
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for this initiative. If you want a reproducer to test against: https://igit.ific.uv.es/ferhue/pulse-surfer |
Test Results 17 files 17 suites 3d 6h 16m 48s ⏱️ For more details on these failures, see this check. Results for commit 0d7826f. ♻️ This comment has been updated with latest results. |
|
I tested on @ferdymercury 's reproducer and it seems to work fine. |
ferdymercury
approved these changes
Apr 24, 2025
- fix some broken logic - simplify some functions - improve safety by adding bounds checks where appropriate
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix and improve some old code in
TGNumberEntryby:This is not an exhaustive pass on the file, as there are many other places that could use a pass or a rewrite. However it should address some of the more glaring safety concerns - particularly, it removes all uses of
strcpyand the coverity annotations.I haven't tested this code yet so I'm opening this as a draft PR. Feel free to comment on it already.
Checklist:
This PR fixes #17334