Skip to content

[test] disable web tests if davix is OFF #18458

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Apr 24, 2025

Conversation

ferdymercury
Copy link
Contributor

This Pull request:

Changes or fixes:

Fixes #18453

Sibling PR: root-project/roottest#1308

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@ferdymercury ferdymercury requested a review from linev April 22, 2025 11:07
Copy link

github-actions bot commented Apr 22, 2025

Test Results

    17 files      17 suites   4d 0h 41m 19s ⏱️
 2 730 tests  2 730 ✅ 0 💤 0 ❌
45 033 runs  45 033 ✅ 0 💤 0 ❌

Results for commit 866961b.

♻️ This comment has been updated with latest results.

@dpiparo dpiparo self-requested a review April 22, 2025 13:15
Copy link
Member

@dpiparo dpiparo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR! It is correct logically, however one can trim down the changes by using the already available preprocessor macro R__HAS_DAVIX in the C++ code and be done with it.

@ferdymercury ferdymercury requested a review from dpiparo April 22, 2025 13:41
@ferdymercury ferdymercury marked this pull request as ready for review April 22, 2025 17:15
@ferdymercury ferdymercury requested a review from gganis as a code owner April 22, 2025 17:15
@ferdymercury ferdymercury requested a review from pcanal April 22, 2025 17:26
@ferdymercury ferdymercury added this to the 6.38.00 milestone Apr 22, 2025
@ferdymercury ferdymercury requested a review from bellenot as a code owner April 23, 2025 06:51
@dpiparo dpiparo removed the request for review from gganis April 23, 2025 14:01
@dpiparo
Copy link
Member

dpiparo commented Apr 24, 2025

great PR. Thanks.

@dpiparo dpiparo merged commit 7b461b5 into root-project:master Apr 24, 2025
21 of 22 checks passed
@dpiparo dpiparo self-assigned this Apr 24, 2025
@ferdymercury ferdymercury deleted the davixtests branch April 24, 2025 06:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some test fails on linux with Davix disabled
4 participants