[math] implement genvector custom axis rotation #18462
Open
+43
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 15 files 15 suites 3d 9h 2m 10s ⏱️ Results for commit 24cc921. ♻️ This comment has been updated with latest results. |
mdessole
reviewed
Apr 23, 2025
| @@ -332,6 +338,38 @@ namespace ROOT { | |||
| vrot.SetXYZ(x2, y2, v.Z()); | |||
| return vrot; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
why not implementing an access operator in the Rotation3D class instead?
There was a problem hiding this comment.
Thanks Monica for the swift review.
Wrt using the Rotation3D class: It's maybe a bit less efficient to define an AxisAngle, then a TRotation3D, and finally calling Rotate, than doing the direct multiplication?
There was a problem hiding this comment.
You have a point. However, I agree with the author of the forum post you mentioned, it's counter-intuitive that a TRotation3D does not work with Rotate...
2 tasks
as suggested by mdessole
mdessole
approved these changes
Apr 24, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Fixes https://root-forum.cern.ch/t/tvector3-rotate-to-arbitrary-rotation-using-xyzvector/63244
Checklist: