Skip to content

[ntuple] Move RCluster/RClusterPool out of Experimental #18473

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[ntuple] Move RCluster/RClusterPool out of Experimental #18473

wants to merge 2 commits into from

Conversation

silverweed
Copy link
Contributor

@silverweed silverweed commented Apr 23, 2025 •
edited
Loading

  • tested changes locally
  • updated the docs (if necessary)

@silverweed silverweed requested review from hahnjo and enirolf April 23, 2025 07:05
@silverweed silverweed self-assigned this Apr 23, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2025 •
edited
Loading

Test Results

    17 files      17 suites   3d 21h 1m 11s ⏱️
 2 730 tests  2 730 ✅ 0 💤 0 ❌
45 029 runs  45 029 ✅ 0 💤 0 ❌

Results for commit a2abd36.

♻️ This comment has been updated with latest results.

enirolf
enirolf approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@enirolf enirolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! FYI, the [skip-ci] tag doesn't really apply to commit messages. Instead [NFC] (non-functional change) is more commonly used.

This was referenced Apr 23, 2025
Closed
Open
@ferdymercury ferdymercury added this to the 6.38.00 milestone Apr 23, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hahnjo hahnjo hahnjo approved these changes

@enirolf enirolf enirolf approved these changes

@jblomer jblomer Awaiting requested review from jblomer jblomer is a code owner

@pcanal pcanal Awaiting requested review from pcanal pcanal is a code owner

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

Assignees

@silverweed silverweed

Labels
in:RNTuple
Projects
None yet
Milestone
6.38.00
Development

Successfully merging this pull request may close these issues.
4 participants
@silverweed @hahnjo @enirolf @ferdymercury