Skip to content

[sql] remove deprecated options and code #18634

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
May 17, 2025

Conversation

ferdymercury
Copy link
Collaborator

@ferdymercury ferdymercury commented May 7, 2025

This Pull request:

Changes or fixes:

Removes deprecated build options mysql odbc pgsql. It also does some cleanup of leftovers from the already deleted oracleoption.

@cern-sft-spi FYI

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

Copy link

github-actions bot commented May 8, 2025

Test Results

    19 files      19 suites   3d 15h 41m 0s ⏱️
 2 745 tests  2 734 ✅ 0 💤 11 ❌
50 721 runs  50 710 ✅ 0 💤 11 ❌

For more details on these failures, see this check.

Results for commit f9e6946.

♻️ This comment has been updated with latest results.

@ferdymercury ferdymercury marked this pull request as ready for review May 8, 2025 08:43
Copy link
Member

@linev linev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugin for TXNetFile can remain

Also all tutorials/io/sql can remain - they show usage of TSQLServer API
and can be useful for understanding how it can be used.
Even when examples refer to mysql or oracle DB.

@andresailer
Copy link
Contributor

The LCGCMake recipes have been updated. Thanks for the heads-up!

even if they speak about sqlite or odbc, as suggested by linev
@ferdymercury ferdymercury requested a review from linev May 8, 2025 12:13
@guitargeek
Copy link
Contributor

@ferdymercury, please let us know when this PR is ready from your side so it can be merged.

@ferdymercury
Copy link
Collaborator Author

Thanks! It's ready now to "squash and merge" in my opinion, I have just added a mention to the 6.38 release note removal list.

@ferdymercury ferdymercury added this to the 6.38.00 milestone May 15, 2025
@dpiparo dpiparo merged commit 5cc9ccc into root-project:master May 17, 2025
38 of 43 checks passed
@ferdymercury ferdymercury deleted the rmdepr branch May 17, 2025 08:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants