Do not execute the test case that assumes geometry is there if there is no geometry

[dpiparo]

Noticed while doing unrelated work.

[ferdymercury]

Thanks!!

There is this other file using unguarded geom:

main/src/g2root.f

Maybe the easiest way could be to change:

gSystem->Load("libGeom");

with

R_ASSERT(gSystem->Load("libGeom") >= 0); // g2root needs ROOT built with geom active

[github-actions]

Test Results

    18 files      18 suites   3d 20h 29m 39s ⏱️
 2 733 tests  2 733 ✅ 0 💤 0 ❌
48 031 runs  48 031 ✅ 0 💤 0 ❌

Results for commit 025e5ac.

[dpiparo]

Hi @ferdymercury : thanks a lot. I would maybe build the executable only if the geom is active, would that maybe be a solution too?

[ferdymercury]

Hi @ferdymercury : thanks a lot. I would maybe build the executable only if the geom is active, would that maybe be a solution too?

Thanks to you. Mmm not sure, according to https://linux.die.net/man/1/g2root
g2root is only creating a text C++ macro, not really running ROOT. So even if geom is not installed, g2root should be able to work without problems. Now if someone gets that macro, sends it over SSH to another computer, and that other computer has no geom, it should get the error. That's why I was suggesting to edit the created C++ test macro with a more sensible error message. (Otherwise you would get gGeoManager error not defined.)