core: Add semantic ROOT::EnableImplicitMT #18694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcanal
commented
May 12, 2025
Instead of specificy the number of core, the new overload can be specified to select a configuration type. Currently the following 2 configuration are supported: ROOT::EIMTConfig::kWholeMachine ROOT::EIMTConfig::kExistingTBBArena calling ``` ROOT::EnableImplicitMT(ROOT::EIMTConfig::kExistingTBBArena); ``` will attach to an existing TBB Arena instead of creating a new one. This fixes root-project#18301
pcanal
commented
May 12, 2025
Dr15Jones
reviewed
May 12, 2025
Dr15Jones
reviewed
May 12, 2025
Test Results 19 files 19 suites 3d 15h 9m 49s ⏱️ For more details on these failures, see this check. Results for commit 436a137. ♻️ This comment has been updated with latest results. |
Dr15Jones
approved these changes
May 14, 2025
pcanal
requested review from
hahnjo and
hageboeck
and removed request for
bellenot
dpiparo
approved these changes
May 15, 2025
hahnjo
reviewed
May 15, 2025
hageboeck
reviewed
May 15, 2025
|
Can we have this PR backported all the way back to 6.32? Thanks! |
pcanal
added a commit
to pcanal/root
that referenced
this pull request
May 16, 2025
Instead of specificy the number of core, the new overload can be specified to select a configuration type. Currently the following 2 configuration are supported: ROOT::EIMTConfig::kWholeMachine ROOT::EIMTConfig::kExistingTBBArena calling ``` ROOT::EnableImplicitMT(ROOT::EIMTConfig::kExistingTBBArena); ``` will attach to an existing TBB Arena instead of creating a new one. (cherry picked from commit eb0b903)
pcanal
added a commit
to pcanal/root
that referenced
this pull request
May 16, 2025
Instead of specificy the number of core, the new overload can be specified to select a configuration type. Currently the following 2 configuration are supported: ROOT::EIMTConfig::kWholeMachine ROOT::EIMTConfig::kExistingTBBArena calling ``` ROOT::EnableImplicitMT(ROOT::EIMTConfig::kExistingTBBArena); ``` will attach to an existing TBB Arena instead of creating a new one. (cherry picked from commit eb0b903)
2 tasks
pcanal
added a commit
to pcanal/root
that referenced
this pull request
May 16, 2025
Instead of specificy the number of core, the new overload can be specified to select a configuration type. Currently the following 2 configuration are supported: ROOT::EIMTConfig::kWholeMachine ROOT::EIMTConfig::kExistingTBBArena calling ``` ROOT::EnableImplicitMT(ROOT::EIMTConfig::kExistingTBBArena); ``` will attach to an existing TBB Arena instead of creating a new one. (cherry picked from commit eb0b903)
pcanal
added a commit
that referenced
this pull request
May 17, 2025
Instead of specificy the number of core, the new overload can be specified to select a configuration type. Currently the following 2 configuration are supported: ROOT::EIMTConfig::kWholeMachine ROOT::EIMTConfig::kExistingTBBArena calling ``` ROOT::EnableImplicitMT(ROOT::EIMTConfig::kExistingTBBArena); ``` will attach to an existing TBB Arena instead of creating a new one. (cherry picked from commit eb0b903)
pcanal
added a commit
that referenced
this pull request
May 17, 2025
Instead of specificy the number of core, the new overload can be specified to select a configuration type. Currently the following 2 configuration are supported: ROOT::EIMTConfig::kWholeMachine ROOT::EIMTConfig::kExistingTBBArena calling ``` ROOT::EnableImplicitMT(ROOT::EIMTConfig::kExistingTBBArena); ``` will attach to an existing TBB Arena instead of creating a new one. (cherry picked from commit eb0b903)
pcanal
added a commit
that referenced
this pull request
May 17, 2025
Instead of specificy the number of core, the new overload can be specified to select a configuration type. Currently the following 2 configuration are supported: ROOT::EIMTConfig::kWholeMachine ROOT::EIMTConfig::kExistingTBBArena calling ``` ROOT::EnableImplicitMT(ROOT::EIMTConfig::kExistingTBBArena); ``` will attach to an existing TBB Arena instead of creating a new one. (cherry picked from commit eb0b903)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of specificy the number of core, the new overload can be specified to select a configuration type. Currently the following 2 configuration are supported:
ROOT::EIMTConfig::kWholeMachine
ROOT::EIMTConfig::kExistingTBBArena
calling
will attach to an existing TBB Arena instead of creating a new one.
This fixes #18301
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #