Skip to content

[core] add more dicts for deque variants #18698

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[core] add more dicts for deque variants #18698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36151bc
[core] add more dicts for deque variants
ferdymercury May 13, 2025
2722bf7
[io] add test for deque longdouble class-size
ferdymercury May 13, 2025
772d004
[core] use all int types, but not long double for deque dicts
ferdymercury May 13, 2025
27134e7
[nfc] newl
ferdymercury May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/clingutils/src/dequeLinkdef.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,13 @@

#pragma extra_include "deque";

#pragma create TClass deque<unsigned short>;
#pragma create TClass deque<unsigned int>;
#pragma create TClass deque<unsigned long>;
#pragma create TClass deque<short>;
#pragma create TClass deque<int>;
#pragma create TClass deque<long>;
#pragma create TClass deque<float>;
#pragma create TClass deque<double>;
#pragma create TClass deque<void*>;
#pragma create TClass deque<char*>;

13 changes: 13 additions & 0 deletions core/clingutils/test/TClingUtilsTests.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,14 @@
*************************************************************************/

#include <TClingUtils.h>
#include <TClass.h>

#include <ROOT/FoundationUtils.hxx>

#include "gtest/gtest.h"

#include <fstream>
#include <deque>

TEST(TClingUtilsTests, GetCppName)
{
Expand Down Expand Up @@ -85,3 +87,14 @@ TEST(TClingUtilsTests, GetRealPath)
std::remove("./realfile2");
#endif // not R__WIN32
}

TEST(TClingUtilsTests, CollectionSizeof)
{
// https://its.cern.ch/jira/browse/ROOT-9889
EXPECT_EQ(sizeof(std::deque<short>), TClass::GetClass("std::deque<short>")->GetClassSize());
EXPECT_EQ(sizeof(std::deque<unsigned short>), TClass::GetClass("std::deque<unsigned short>")->GetClassSize());
EXPECT_EQ(sizeof(std::deque<int>), TClass::GetClass("std::deque<int>")->GetClassSize());
EXPECT_EQ(sizeof(std::deque<unsigned int>), TClass::GetClass("std::deque<unsigned int>")->GetClassSize());
EXPECT_EQ(sizeof(std::deque<long>), TClass::GetClass("std::deque<long>")->GetClassSize());
EXPECT_EQ(sizeof(std::deque<unsigned long>), TClass::GetClass("std::deque<unsigned long>")->GetClassSize());
}
Loading