Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update example to remove warning from osmdata for #59 #69

Merged
merged 2 commits into from
Feb 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: osmplotr
Title: Bespoke Images of 'OpenStreetMap' Data
Version: 0.3.5.019
Version: 0.3.5.021
Authors@R:
c(person(given = "Mark",
family = "Padgham",
Expand Down
4 changes: 2 additions & 2 deletions R/make-osm-map.R
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@
#' # 'london' data for highways and parks.
#' dat <- make_osm_map (osm_data = london, structures = structs)
#' # or download data automatically using a defined bounding boox
#' bbox <- get_bbox (c (-0.15, 51.5, -0.10, 51.52))
#' dat <- make_osm_map (bbox = bbox, structures = structs)
#' bbox <- get_bbox (c (-0.14, 51.51, -0.12, 51.52))
#' \donttest{
#' dat <- make_osm_map (bbox = bbox, structures = structs)
#' print_osm_map (dat$map)
#' }
#' @family construction
Expand Down
8 changes: 4 additions & 4 deletions codemeta.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
"codeRepository": "https://github.com/ropensci/osmplotr",
"issueTracker": "https://github.com/ropensci/osmplotr/issues",
"license": "https://spdx.org/licenses/GPL-3.0",
"version": "0.3.5.019",
"version": "0.3.5.021",
"programmingLanguage": {
"@type": "ComputerLanguage",
"name": "R",
"url": "https://r-project.org"
},
"runtimePlatform": "R version 4.3.3 (2024-02-29)",
"runtimePlatform": "R version 4.4.2 (2024-10-31)",
"author": [
{
"@type": "Person",
Expand Down Expand Up @@ -269,12 +269,12 @@
},
"SystemRequirements": {}
},
"fileSize": "12101.377KB",
"fileSize": "1371.45KB",
"releaseNotes": "https://github.com/ropensci/osmplotr/blob/master/NEWS.md",
"readme": "https://github.com/ropensci/osmplotr/blob/main/README.md",
"contIntegration": [
"https://github.com/ropensci/osmplotr/actions?query=workflow%3AR-CMD-check",
"https://codecov.io/gh/ropensci/osmplotr"
"https://app.codecov.io/gh/ropensci/osmplotr"
],
"developmentStatus": "https://www.repostatus.org/",
"review": {
Expand Down
17 changes: 4 additions & 13 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,27 +1,18 @@
# CRAN notes for osmplotr_v0.3.6 re-submission

This is a re-submission of a previously archived package. The submission may
generate one single note regarding installed size of ~6MB, which is due to the
vignettes. These produce many graphical files illustrating the package's
functionality. Every effort has been made to reduce this as much as possible,
including reducing the resolution of these images to the coarsest practicable
scale. Halving the resolution again (from current 72 to 36 dpi) only decreases
the final package size by around 200 kB.
This is a re-submission of a previously archived package. The submission may generate one single note regarding installed size of ~6MB, which is due to the vignettes. These produce many graphical files illustrating the package's functionality. Every effort has been made to reduce this as much as possible, including reducing the resolution of these images to the coarsest practicable scale. Halving the resolution again (from current 72 to 36 dpi) only decreases the final package size by around 200 kB.

This re-submission also rectifies several issues pointed out in an email from
7th Feb 2025:
This re-submission also rectifies several issues pointed out in an email from 7th Feb 2025:

- Return values have been documented in all functions
- Most `\dontrun` statements have been reduced, and converted to `donttest`. A
few nevertheless remain, as the example code makes external API calls to
download data. The following functions retain `dontrun` statements only around
code which makes external API calls:
- Most `\dontrun` statements have been reduced, and converted to `donttest`. A few nevertheless remain, as the example code makes external API calls to download data. The following functions retain `dontrun` statements only around code which makes external API calls:
- `add_osm_groups()`
- `adjust_colours()`,
- `add_osm_objects()`
- `extract_osm_objects()`
- `osm_line2poly()`
- `connect_highways()`.
- All previous uses of `cat()` have been removed, and replaced with `message()`.


## Test environments
Expand Down
4 changes: 2 additions & 2 deletions man/make_osm_map.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading