-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
PID controller feedforward control #1270
Comments
There is already a service for that:
The change you are proposing is removing the ros2_controllers/pid_controller/src/pid_controller.cpp Lines 451 to 452 in 1c4d58e
The documentation is a bit cryptic here But I think the idea was to have position and velocity references, with velocity command interface. Then the feedforward part is the velocity of the reference (and therefore |
Originally posted by @catcracker in #1260 (comment)
Is your feature suggestion related to a problem? Please describe.
While using the PID controller and tricycle controller, there might be room for improvement in the following areas:
Describe the solution you'd like to see
For both PID and Tricycle Controllers:
For PID Controller:
It might be necessary to investigate and address the issue with feedforward_gain application. Currently, in the pid_controller.cpp file (lines 444-445), the result appears to always be 0.000.
A potential fix to consider might be:
tmp_command= reference_interfaces_[i] * params_.gains.dof_names_map[params_.dof_names[i]].feedforward_gain;
The text was updated successfully, but these errors were encountered: