ASan: Run with verify_asan_link_order=0. #3491
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like this conflates the issues of rr itself running under asan and rr tracing something running under asan (which itself may be rr). If it's just a matter of fixing the tests, I think this should be in |
|
Thanks, let me try how it works when I put it into the default options. |
This comment was marked as outdated.
This comment was marked as outdated.
bernhardu
force-pushed
the
cmake-option-asan-part2
branch
from
4f90a93 to
e07e77e
Compare
|
I pushed a new version with no longer setting the environment, instead using |
bernhardu
force-pushed
the
cmake-option-asan-part2
branch
from
e07e77e to
b4f7b0c
Compare
|
Changes:
|
Avoids error message: ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD. Affected tests: nested_detach nested_detach_kill nested_detach_kill_stuck nested_detach_stop nested_detach_wait
bernhardu
force-pushed
the
cmake-option-asan-part2
branch
from
b4f7b0c to
35e0f55
Compare
|
Just a rebase to current tip. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids error message:
Affected tests:
(These tests may also need the
ASan: Copy just used pages from ANONYMOUS|NORESERVE mappings.patch too.)