-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Not handling skip creation part in case of api key not defined for a stage #47
base: master
Are you sure you want to change the base?
Conversation
removeded not needed return statement
@sromic - can you please update the version in package.json so that this can be merged |
@rrahul963 sorry, I missed this :S. |
@rrahul963 any plans to have this PR merged? |
@sromic - can you update the version on package.json file and run the builds |
@rrahul963 done. Please review and merge is looks good. Ty! |
@rrahul963 any plans to merge this PR? It's been sitting for a while now :) |
mm maby , same issue when run sls remove ?, error in line 407 TypeError: apiKeys is not iterable |
could be, let me revisit that as well, ty! |
@cvargas-xbrein , @rrahul963 ty, added this for remove hook as well. |
Hi @cvargas-xbrein, @rrahul963 I would appreciate a review to this PR. Ty! |
Hi @cvargas-xbrein , @rrahul963 any news on getting this reviewed and potentially merged? Ty in advance! |
@rrahul963 sorry for bothering, any plans to have this reviewed and merged in? Thanks! |
Default an apiKey array to an empty array in case of api keys not defined for a stage.