-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use yarn 3.6.3 #788
base: main
Are you sure you want to change the base?
Use yarn 3.6.3 #788
Conversation
@cpsievert Do you know if this Line 21 in 6797df4
We can apparently get similar behavior using |
With `yarn workspaces focus -A --production` See https://yarnpkg.com/cli/workspaces/focus
IIRC it's there so we can essentially rename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After spending a bit trying to get this to work, I don't think it's currently worth the effort, unless someone else has an easy solution for asking yarn
to install just the development dependencies and have them installed into inst/node_modules
reliably.
In short, this PR moves bslib from classic yarn to modern yarn, which has more downstream changes than I think we want to take on right now. I think we should table this for now and revisit this post-conf.
The problem I had was that when I ran |
bslib currently uses whichever version of yarn is installed on the system. This PR updates it to use a fixed version of yarn, so that the behavior is predictable across systems. (This is how things are set up for the https://github.com/rstudio/shiny repository.)