-
Notifications
You must be signed in to change notification settings - Fork 629
Setting sample config for container development #1992
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
(Someone else needs to review this PR, due to lacking knowledge about docker.) Does this imply that I would run some third-party docker image on my system? |
@stomar The image used is in the $ docker-compose up After that, when you see the rake serve message go to localhost:9292/ on your browser and check if everything is ok. |
@alaxalves Please, update your Gemfile.lock to use bundler 2.0 or greater. When using the container the following is throw:
See jekyll/jekyll#7463 for more information. |
It's done! |
README.md
Outdated
to generate the website and start a local web server | ||
|
||
|
||
Open [http://localhost:9292/](http://localhost:9292/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use <http://localhost:9292/>
instead of [http://localhost:9292/](http://localhost:9292/)
.
docker-compose.yml
Outdated
services: | ||
web: | ||
container_name: ruby-lang | ||
image: ruby:2.6.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this can be updated? It seems that 2.6.4 is available: https://hub.docker.com/_/ruby. Currently .travis.yml specified the version to 2.6.3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yous do I use the same version as travis or do I update Travis to use 2.6.4 as well?
Co-Authored-By: Júlio Campos <jcserracampos@gmail.com>
@alaxalves Saying to access through localhost is incorrect, is not? |
I think that you have an specific use case. For what I'm aware of latest Docker CE doesn't use a VM to "simulate" a Docker environment on MacOS anymore, now it uses the host's kernel, as in linux systems. Thus you can access your containerized service through localhost. |
I use kyperkit and can not use localhost. |
Added yaml file with sample docker configuration to make easier and faster developing to ruby-lang. Also added examples in README on how to use either Docker or Docker-Compose.