Skip to content

Fix binary tool version check #1330

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cyqsimon
Copy link

I was wondering why wasm-pack is insisting on pulling and building cargo-generate despite there already being one at /usr/bin/cargo-generate. I'm on EndeavourOS too so it is the newest version 0.18.4.

Turns out, the version check logic no longer works for the newest cargo-generate. Right now cargo-generate --version prints cargo generate 0.18.4, which means the current logic is actually evaluating "generate" == "0.18.4". The same problem also exists for wasm-opt. This patch fixes this, along with adding a few helpful debug prints.

You can test before and after using RUST_LOG=debug cargo run -- new --mode no-install version-test.

@cyqsimon
Copy link
Author

Hmm. Seems like depending on the specific build used, wasm-bindgen --version may contain a commit hash (e.g. wasm-bindgen 0.2.87 (f0a8ae3b9)). Annoying.

I guess this is now a situation that calls for regex.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant