Skip to content

Hotfix: fix versioning + trailing junk error #145

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 2025032500 v1.5.8
* Hotfix: correct further trailing junk after parameter
* Versioning error fix


## 2025031700 v1.5.8
* Correct Privacy API tests
* Iss129: remove print_error deprecated function
8 changes: 4 additions & 4 deletions locallib.php
Original file line number Diff line number Diff line change
@@ -1024,15 +1024,15 @@ function pdfannotator_get_questions($courseid, $context, $questionfilter) {
. "JOIN {course_modules} cm ON p.id = cm.instance "
. "LEFT JOIN {pdfannotator_votes} v ON c.id=v.commentid "
. "LEFT JOIN {pdfannotator_comments} answ ON answ.annotationid = a.id "
. "WHERE c.isquestion = 1 AND p.course = ? AND cm.id $insql";
. "WHERE c.isquestion = 1 AND p.course = ? AND cm.id $insql ";
if ($questionfilter == 0) {
$sql = $sql . ' AND c.solved = 0 ';
}
if ($questionfilter == 1) {
$sql = $sql . ' AND NOT c.solved = 0 ';
}
$sql = $sql . "GROUP BY a.id, p.name, p.usevotes, cm.id, c.id, a.page, a.pdfannotatorid, c.content, c.userid, c.visibility,"
. "c.timecreated, c.isdeleted, c.ishidden, c.isquestion";
$sql = $sql . "GROUP BY a.id, p.name, p.usevotes, cm.id, c.id, a.page, a.pdfannotatorid, c.content, c.userid, c.visibility, "
. "c.timecreated, c.isdeleted, c.ishidden, c.isquestion ";
$params = array_merge([$courseid], $inparams);
$questions = $DB->get_records_sql($sql, $params);

@@ -1194,7 +1194,7 @@ function pdfannotator_get_answers_for_this_user($courseid, $context, $answerfilt

if ($answerfilter == 0) { // Either: get all answers in this annotator.
$sql = "SELECT c.id AS answerid, c.content AS answer, c.userid AS userid, c.visibility, "
. "c.timemodified, c.solved AS correct, c.ishidden AS answerhidden, a.id AS annoid, a.page, q.id AS questionid,"
. "c.timemodified, c.solved AS correct, c.ishidden AS answerhidden, a.id AS annoid, a.page, q.id AS questionid, "
. "q.userid AS questionuserid, c.isquestion, c.annotationid, "
. "q.visibility AS questionvisibility, "
. "q.content AS answeredquestion, q.isdeleted AS questiondeleted, q.ishidden AS questionhidden, p.id AS annotatorid, "
2 changes: 1 addition & 1 deletion version.php
Original file line number Diff line number Diff line change
@@ -25,7 +25,7 @@
defined('MOODLE_INTERNAL') || die();

$plugin->component = 'mod_pdfannotator';
$plugin->version = 2025031700;
$plugin->version = 2025032500;
$plugin->release = 'PDF Annotator v1.5 release 8';
$plugin->requires = 2021051700;
$plugin->maturity = MATURITY_STABLE;
Loading