more code cleanup and pep 8 work #41

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Open

decantr wants to merge 6 commits into sameerkumar18:master from decantr:master

decantr commented Oct 22, 2017

changes made

more work towards overall #3 goal

random digits method removed in favour of an inline randint call 1fa0619
renamed get_joke to getJoke so app.py works again 87e9519
getJoke started at index 1 meaning it would never return the first joke e6ff3da
removed the ascii encoding and decoding as utf-8 is already enforced 4187f26

decantr added 6 commits

October 22, 2017 00:30


          removed random_digits as it's unneeded

1fa0619


          only import randint from random

ea67071


          change method name to camelCase so app works again. remove excess lines

87e9519


          start index from 0 so as not to miss the first joke

e6ff3da


          -1 from length to avoid edge case overflow

1b69496


          removed uneeded ascii encoding and further pep 8 convention

4187f26

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet