-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
WIP Replace ava with vitest for frontend unit testing #8479
base: master
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
For the most part, only the following changes needed to be done:
|
At the moment we have a a complicated and somewhat outdated stack for frontend testing:
esbuild
nodejs
while the whole codebase already uses ES modulesmockRequire
is also commonJS and very confusingnodejs
withava
frameworkThis workflow for testing TS, ESM and React code in node is configured very differently from the regular browser builds and is not very well supported out-of-the-box by either
ava
or the other tools.vitest
is very modern, works out-of-the-box with our current frontend setup without any additional configs. n this PR I migrated the frontend unit tests tovitest
in an effort to rid ourselves ofava´ and many
esbuild` configs.URL of deployed dev instance (used for testing):
Steps to test:
TODOs:
Issues:
(Please delete unneeded items, merge only when none are left open)