Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor remove-element-from-list #28

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Refactor remove-element-from-list #28

merged 2 commits into from
Aug 3, 2021

Conversation

lassik
Copy link
Member

@lassik lassik commented Jul 31, 2021

@jcubic OK?

lassik added 2 commits July 31, 2021 16:31

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
list -> lst
iter -> loop
@lassik lassik changed the title Lassik remove Refactor remove-element-from-list Jul 31, 2021
@lassik
Copy link
Member Author

lassik commented Aug 3, 2021

No response in 3 days, so merging.

@lassik lassik merged commit 3a96919 into master Aug 3, 2021
@lassik lassik deleted the lassik-remove branch August 3, 2021 08:37
@jcubic
Copy link
Contributor

jcubic commented Aug 3, 2021

Sorry was reading the emails on a phone and missed that you wanted a review from me. The code looks good. As discussed loop is better.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants