Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Emacs Unicode from lockywolf #51

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Add Emacs Unicode from lockywolf #51

merged 2 commits into from
Aug 17, 2021

Conversation

lassik
Copy link
Member

@lassik lassik commented Aug 17, 2021

@lockywolf OK?

@ghost
Copy link

ghost commented Aug 17, 2021

I don't think that avoiding the seq library is a good idea. It's very schemy, basically made in the spirit of srfi-1, non-mutative, whereas append is actually append!, and I think it will be destructively appending the list to itself (doubling the length) each time you run scheme-mode. But I'm not very sure, because I avoid using "old lisp" primitives as much as possible.

@lassik
Copy link
Member Author

lassik commented Aug 17, 2021

Since the cookbook is intended to have wide applicability, I switched to append which comes standard with Emacs. append is the same in Emacs Lisp (and Common Lisp) as it is in Scheme: it copies all except the last argument. nconc is the ELisp and CL function to append lists destructively.

@ghost
Copy link

ghost commented Aug 17, 2021

Seq also comes with standard Emacs (https://www.gnu.org/software/emacs/manual/html_node/elisp/Sequence-Functions.html), and is, in all respects, a more consistent and compatible.

Excessive compatibility with something that changes as quickly as Emacs, and in a cosmetic domain (which is itself subjective) makes no sense.

You are right with respect to append, and I am wrong, but, again, I see no benefit in using it.

@lassik
Copy link
Member Author

lassik commented Aug 17, 2021

OK. I don't understand your arguments, but let's go with seq-concatenate since it's your solution.

@lassik lassik merged commit a2e30bd into master Aug 17, 2021
@lassik lassik deleted the lassik-emacs-unicode branch August 17, 2021 15:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant