Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added ability to specify custom filename during model generation. #962

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

timkatee
Copy link

@timkatee timkatee commented Aug 24, 2021

Added ability to specify custom filename during model generation. Developers can therefore ensure consistency for their naming conventions.

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Description of change

@WikiRik
Copy link
Member

WikiRik commented Nov 6, 2021

This is a nice addition! Could you add some tests to this? And maybe some additional documentation to https://github.com/sequelize/sequelize/blob/main/docs/manual/other-topics/migrations.md

@timkatee
Copy link
Author

Sure @WikiRik let me do...

@WikiRik
Copy link
Member

WikiRik commented Apr 27, 2022

Thanks! In the meantime we have moved the docs file to https://github.com/sequelize/website/blob/main/docs/other-topics/migrations.md btw

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants