Skip to content

Update typesystem.rs, added MYSQL_TYPE_NULL #542

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luca-trigili
Copy link

No description provided.

@wangxiaoying
Copy link
Contributor

wangxiaoying commented Sep 18, 2023

Hi @luca-trigili , thanks for the PR!

Can you also add a test for the null type in our CI? You can refer to this commit: Amar1729@3391f71 which adds a new type to postgres. Basically you need to add a new test type null to mysql.sql (new column in create table, insert values) and then modify corresponding tests (here and here) in test_mysql.py by checking the result of this new type.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants