Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Standardize components, fix the Close component missing data-slot="dialog-close" #6947

Open
wants to merge 3 commits into
base: canary
Choose a base branch
from
Open

Standardize components, fix the Close component missing data-slot="dialog-close" #6947

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b9d0f6
Standardize components, fix the Close component missing data-slot="di…
rockey2020 Mar 17, 2025
11639e0
Merge pull request #1 from rockey2020/rockey2020-patch-1
rockey2020 Mar 17, 2025
85467a7
Merge pull request #2 from rockey2020/canary
rockey2020 Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/v4/registry/new-york-v4/ui/dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ function DialogContent({
{...props}
>
{children}
<DialogPrimitive.Close className="ring-offset-background focus:ring-ring data-[state=open]:bg-accent data-[state=open]:text-muted-foreground absolute top-4 right-4 rounded-xs opacity-70 transition-opacity hover:opacity-100 focus:ring-2 focus:ring-offset-2 focus:outline-hidden disabled:pointer-events-none [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4">
<DialogClose className="ring-offset-background focus:ring-ring data-[state=open]:bg-accent data-[state=open]:text-muted-foreground absolute top-4 right-4 rounded-xs opacity-70 transition-opacity hover:opacity-100 focus:ring-2 focus:ring-offset-2 focus:outline-hidden disabled:pointer-events-none [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4">
<XIcon />
<span className="sr-only">Close</span>
</DialogPrimitive.Close>
</DialogClose>
</DialogPrimitive.Content>
</DialogPortal>
)
Expand Down