refactor(ui): streamline dialog structure and inputs #4755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otavio
reviewed
Apr 24, 2025
Simplified markup by collapsing multiline tags and aligning props. Refactored table headers to use a loop with dynamic labels. Created a function to normalize the new Headers variable logic on tests. Improved device search behavior and keyboard shortcut handling. Fixed test selectors to match updated header labeling logic.
luannmoreira
force-pushed
the
refactor/quick-connection-dialog-improvements
branch
from
523e6f0 to
a67fe0b
Compare
otavio
approved these changes
Apr 25, 2025
luizhf42
approved these changes
Apr 28, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the Quick Connection dialog to improve its structure,
readability, and maintainability. It also enhances the user interaction
experience and brings consistency to both the UI and tests.
Changes
v-text-fieldstyling to useoutlinedvariant and surface backgroundheadersarray for cleaner codeuseMagicKeys"There are currently no devices online")
Motivation
These changes streamline the component code, improve testability, and lay the
groundwork for future enhancements like dynamic headers or advanced search.
Testing
QuickConnection.spec.ts)