-
-
Notifications
You must be signed in to change notification settings - Fork 629
Added close connections in quickstart. #2725
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Added close connections in quickstart. #2725
Conversation
Close connections were missing so I have added it in quickstart.
Thanks, @sanketgandhi876 🙋🏻♂️ For the "Using Prepared Statements" (promise-based) example, I think it's better to set the connection before the
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2725 +/- ##
=======================================
Coverage 90.33% 90.33%
=======================================
Files 71 71
Lines 15731 15731
Branches 1344 1344
=======================================
Hits 14210 14210
Misses 1521 1521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Yup, done! |
@sanketgandhi876, to fix the lint errors, you can run |
Close connections were missing so I have added it in quickstart.
Fix: #2543