Skip to content

feat: expose hyper tuning module in model_selection #179

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Oct 1, 2022

Conversation

morenol
Copy link
Collaborator

@morenol morenol commented Oct 1, 2022

I just saw that this mod is not being imported so it is not being used and the tests are not running.

I noticed this while reviewing #169

@morenol morenol requested a review from montanalow October 1, 2022 16:11
@morenol
Copy link
Collaborator Author

morenol commented Oct 1, 2022

@codecov-commenter
Copy link

Codecov Report

Merging #179 (5c3e81c) into development (9c59e37) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development     #179      +/-   ##
===============================================
+ Coverage        84.47%   84.62%   +0.14%     
===============================================
  Files               86       86              
  Lines             9940     9948       +8     
===============================================
+ Hits              8397     8418      +21     
+ Misses            1543     1530      -13     
Impacted Files Coverage Δ
src/model_selection/mod.rs 94.04% <ø> (ø)
src/model_selection/hyper_tuning.rs 82.60% <100.00%> (+82.60%) ⬆️
src/optimization/line_search.rs 82.00% <0.00%> (-8.00%) ⬇️
src/svm/svc.rs 87.96% <0.00%> (+0.25%) ⬆️
src/algorithm/neighbour/cover_tree.rs 84.71% <0.00%> (+0.41%) ⬆️
src/linear/logistic_regression.rs 90.80% <0.00%> (+0.73%) ⬆️
src/optimization/first_order/lbfgs.rs 94.44% <0.00%> (+1.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Mec-iS
Mec-iS previously approved these changes Oct 1, 2022
@morenol morenol marked this pull request as ready for review October 1, 2022 17:43
@morenol morenol merged commit 3c62686 into smartcorelib:development Oct 1, 2022
@morenol morenol deleted the lmm/fix-hyper-tuning branch October 1, 2022 17:47
morenol added a commit that referenced this pull request Nov 8, 2022
* feat: expose hyper tuning module in model_selection

* Move to a folder

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants