Refactor memory management and improve platform compatibility for Windows #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `Cargo.toml` to include new Windows-specific dependencies. - Refactored `GrowableMemoryMap` to enhance memory allocation on Windows, including new methods for growing memory and changing permissions. - Simplified atomic operations in `PoolInner` for better clarity and performance. - Removed unused methods in `buffer.rs` to clean up the codebase. - Improved cross-platform compatibility by consolidating common implementations. - All test results give passing results
This was referenced Dec 28, 2024
FlorentinDUBOIS
requested changes
Feb 10, 2025
There was a problem hiding this comment.
Thank you for the pull request!
Besides, @Wonshtrum could you take a look at this pull request?
|
@FlorentinDUBOIS will this get reviewed? |
FlorentinDUBOIS
approved these changes
May 13, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo.tomlto include new Windows-specific dependencies.GrowableMemoryMapto enhance memory allocation on Windows, including new methods for growing memory and changing permissions.PoolInnerfor better clarity and performance.buffer.rsto clean up the codebase.