Skip to content

Pull #34816: Add checkstyle rule UnusedLocalVariable, UnusedLocalMethodCheck #34816

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Pankraz76
Copy link

@Pankraz76 Pankraz76 commented Apr 24, 2025

@Pankraz76 Pankraz76 changed the title Pull #34811: Add checkstyle rule UnusedLocalVariable Pull #34816: Add checkstyle rule UnusedLocalVariable Apr 24, 2025
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 24, 2025
Pankraz76 pushed a commit to Pankraz76/spring-framework that referenced this pull request Apr 24, 2025
Signed-off-by: Vincent Potucek <vpotucek@me.com>
@Pankraz76 Pankraz76 force-pushed the fix-RemoveUnusedLocalVariables-add-UnusedLocalVariable branch from b78e5e0 to da28f5e Compare April 24, 2025 12:50
@Pankraz76 Pankraz76 changed the title Pull #34816: Add checkstyle rule UnusedLocalVariable Pull #34816: Add checkstyle rule UnusedLocalVariable, UnusedLocalMethodCheck Apr 24, 2025
…UnusedLocalMethodCheck

Signed-off-by: Vincent Potucek <vpotucek@me.com>
@Pankraz76 Pankraz76 force-pushed the fix-RemoveUnusedLocalVariables-add-UnusedLocalVariable branch from 8cbeda4 to f7e6d4e Compare April 25, 2025 10:04
@@ -166,13 +167,8 @@ public void verify() {
this.mockServer.expect(requestTo("/number")).andExpect(method(HttpMethod.GET))
.andRespond(withSuccess("8", MediaType.TEXT_PLAIN));

@SuppressWarnings("unused")
String result1 = this.restTemplate.getForObject("/number", String.class);
// result1 == "1"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why no simple assertThat?

@Pankraz76 Pankraz76 marked this pull request as ready for review April 25, 2025 10:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
status: waiting-for-triage An issue we've not yet triaged or decided on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants