feat(native): add toHaveStyle #152
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suany0805
reviewed
Jul 10, 2025
|
|
||
| const error = new AssertionError({ | ||
| actual: this.actual, | ||
| message: `Expected element ${this.toString()} to have style ${JSON.stringify(flattenedStyle)}.`, |
There was a problem hiding this comment.
Do you think there could be a different way of hanlding the style object to string? since that is what users will be reading when a test fails, it should be clear and readable :)
There was a problem hiding this comment.
Would something like this work for us, or do you have a specific error message in mind?
Expected element <View ... /> to have style:
-"background_color": red
-"color": white
There was a problem hiding this comment.
Yes exactly :) that would work
suany0805
reviewed
Jul 23, 2025
|
|
||
| import { AssertiveStyle, StyleObject } from "./types"; | ||
|
|
||
| export function getFlattenedStyle(style: AssertiveStyle): StyleObject { |
There was a problem hiding this comment.
I think we could add this in hour helpers.ts file instead of just creating a new styles.ts file for this
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
toHaveStylematcher for the React Native module