Fixes bug in SelectiveScanFn.forward for when B is not variable and last_state is returned #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function has to return the last_state. # The cuda kernel does a peculiar optimization of not multiplying the state by B if B is not variable! This does not impact MambaInnerFn, because it never returns the state. But SelectiveScanFn may needd to return the last state! Hence the following is needed.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_selective_scan() fails when is_variable_B is False.
Turns out selective_scan_fwd_kernel incorporates an optimization of not multiplying the state by B if B is not variable. This does not impact MambaInnerFn, because MambaInnerFn never returns the state. But SelectiveScanFn may need to return the last_state. The changes to the code fix this problem, by multiplying the last_state by B before returning it when B is not variable.