feat: nwaku (test) #6395
Draft
feat: nwaku (test) #6395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require commits to follow the Conventional Commits, but with |
Jenkins BuildsClick to see older builds (102)
|
gabrielmer
force-pushed
the
feat-integrating-waku-go-bindings-rebased
branch
from
de2aa9e to
6042149
Compare
|
@gabrielmer can you please extract the |
yeah for sure! so adding the vendors in a separate PR so when merged they don't appear in the diff? I assume that if I just remove the changes of the vendors from this PR it won't compile, although I might be missing something |
|
Although now that I think, the |
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (23.73%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6395 +/- ##
===========================================
- Coverage 23.84% 21.45% -2.39%
===========================================
Files 801 802 +1
Lines 104698 128378 +23680
===========================================
+ Hits 24961 27540 +2579
- Misses 76284 97531 +21247
+ Partials 3453 3307 -146
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gabrielmer
force-pushed
the
feat-integrating-waku-go-bindings-rebased
branch
from
2e0a0fe to
66e0050
Compare
adding waku-go-bindings and some changes to nwaku.go cleanup fix compilation errors updating makefile updating type always building libwaku always build libwaku remove nwaku submodule Revert "remove nwaku submodule" This reverts commit e68749b. removing submodule removing libwaku auto libwaku build updating vendors workaround for using pb types adding nwaku_utils.go fixing store requests converting store responses converting from envelope types on received message improving store types conversion fixing cursor conversion fixing crash first rebase attempt improvements more fixes adding unimplemented methods + fixes fixing compilatioj fix crash fix gowaku error fixing store message parsing updating waku-go-bindings fixing waku-go-bindings integration updaring gitignore fixing gowaku compilation Revert "updating vendors" This reverts commit 64edef5. adding missing vendor file fix for bindings vendor temporarily fixing test target fixing statusgo-library target fixing status-cli updating waku-go-bindings improving compilation for non-nwaku cases temporarily moving to waku-go-bindings version that allows go compilation updating waku-go-bindings fixing compilation chore: updating waku-go-bindings and improving makefile fixing makefile
gabrielmer
force-pushed
the
feat-integrating-waku-go-bindings-rebased
branch
from
66e0050 to
0275eb4
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short summary which serves as a squashed-commit message.
A description to understand introduced changes without reading the code.
Important changes:
Closes #