Update URLs to Developer Documentation #5371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElliotFriend
commented
Jul 3, 2024
There was a problem hiding this comment.
These are the async-specific URLs I was having a hard time with.
There was a problem hiding this comment.
great catch @urvisavla!! Thanks
urvisavla
reviewed
Jul 17, 2024
Co-authored-by: urvisavla <urvi.savla@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stellar-docs site has undergone some structural updates/changes. Among other areas, the Horizon API documentation has been affected. This PR aims to make current all references to the developers documentation.
There was one series of links I had a particularly hard time with, and would love to have some feedback on. The
/services/horizon/internal/actions/submit_transaction_async.gohad a bunch of URLs to pages that (I assume) would've included some Async-transaction-submission-specific error codes. Every link that was there gives a 404, and I can't recall ever having seen those async-submission-specific pages. I took a shot at using (guessing, really) the right non-async-specific error pages, but I'm not sure if that's the right move?Edit: I also tried to test the repo locally, but I was getting a lot of db-related errors, and I couldn't quite figure out which environment variables I did or didn't need