Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

5551/xdrill operations #5604

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

Conversation

chowbao
Copy link
Contributor

@chowbao chowbao commented Feb 14, 2025

DO NOT MERGE

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've reviewed the changes in this PR and if I consider them worthwhile for being mentioned on release notes then I have updated the relevant CHANGELOG.md within the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

#5551

xdrill functions for LedgerOperations

Why

Create low level helper functions for operations parsing

Known limitations

  • Refactor of the processor/transforms to be done in separate ticket/pr

This PR replaces chowbao#2

chowbao added 30 commits January 8, 2025 17:33

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
golang/github.com/stellar/go-stellar-xdr-json@v0.0.0-20250203230501-c6fa0788fe99 eval, unsafe 0 111 MB

View full report↗︎

@karthikiyer56
Copy link
Contributor

@chowbao : I think it is best to hold-off on this work until:

  1. P23 changes have gone in
  2. we have finalized on the structuring we want in /ingest - Spike: refactor ingest sdk packaging, demarcate purpose #5595

more details on why here

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants