-
Notifications
You must be signed in to change notification settings - Fork 383
✨(api) add API route to fetch document content #1213
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
This allows API users to process document content, enabling the use of Docs as a headless CMS for instance, or any kind of document processing. Fixes #1206.
Oops
OverheadInstead of using the
This is in line with the existing Utilizing the existing
|
@StephanMeijer Thanks for the review! Your approach is more concise indeed and I implemented all your feedbacks I think. |
Will give it a new review today or tomorrow! |
@sylvinus Can I propose a different style of writing this tomorrow? Need some time to get behind my editor,. |
@StephanMeijer feel free to push on the branch, frankly I don't care that much about the internals, I just badly need the API as a user ;) |
@StephanMeijer hi! Any news on this? Thanks !! |
I've deployed this to our instance and begun testing. One thing I've just realized is that we need to register custom blocks to the server-side editor so they are rendered properly as HTML or Markdown. That seems to introduce a dependency from impress to the y-provider, that didn't exist yet. Or should we put custom blocks in a new, third package? |
FYI, prior art with a route that generated markdown by parsing the yjs blob : 06c26a7 Curious to discuss the benefits of both approaches! |
This allows API users to fetch document content, enabling the use of Docs as a headless CMS for instance, or any kind of document processing, with
/api/v1.0/documents/xyz/content/?content_format=html
URLs.Fixes #1206.