Skip to content

feat: Check if token is a JWT #159

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Nov 10, 2024
Merged

feat: Check if token is a JWT #159

merged 4 commits into from
Nov 10, 2024

Conversation

juancarlospaco
Copy link
Contributor

What kind of change does this PR introduce?

@silentworks
Copy link
Collaborator

I have a PR open for this on the supabase-py repo supabase/supabase-py#977

@juancarlospaco
Copy link
Contributor Author

juancarlospaco commented Nov 6, 2024

But some users may want to import and use a particular API by itself, like using the functions API directly etc, to keep them usable standalone.

I think the Supabase main library should be like a thin layer that amalgamates all other libraries together, a modular way, but the libraries should still be usable standalone and have all their related logic living in themselves.

Let me know any comments and ideas. 🙂

@J0
Copy link
Contributor

J0 commented Nov 7, 2024

Should be fine to check on both supabase-py and have an additional safeguard in functions-py I think. Going to approve but do check in with @silentworks about #977 before merging

@silentworks
Copy link
Collaborator

I think the Supabase main library should be like a thin layer that amalgamates all other libraries together, a modular way, but the libraries should still be usable standalone and have all their related logic living in themselves.

@juancarlospaco I agree with this comment, lets get these merged in then.

@J0 J0 merged commit 44f7b39 into supabase:main Nov 10, 2024
9 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants