Skip to content

feat: add support for batch column add #608

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mahendraHegde
Copy link

@mahendraHegde mahendraHegde commented Sep 5, 2023

What kind of change does this PR introduce?

support to add multiple column to a table

  • change POST /columns to support both object and array of columns
  • change columns.create method to accept array instead of plain object
  • modify and add new test cases

What is the current behavior?

we need to add columns 1 by 1

What is the new behavior?

we will be able send columns as an array(batch) or object(backward compatibility) to the POST /columns endpoint
closes #182

swagger updated

Screenshot 2023-09-06 at 11 04 30 PM Screenshot 2023-09-06 at 11 04 41 PM

@mahendraHegde mahendraHegde requested review from a team as code owners September 5, 2023 22:37
@mahendraHegde mahendraHegde changed the title [WIP]add support to add multiple column to a table add support to add multiple column to a table Sep 7, 2023
@mahendraHegde mahendraHegde changed the title add support to add multiple column to a table feat: add support for batch column add Sep 7, 2023
@mahendraHegde
Copy link
Author

@soedirgo PR is ready, plz review

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support batch POST (for columns for starters)
1 participant