Skip to content

Replace to HTTPTypes.HTTPRequest from Helpers.HTTPRequest #568

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

zunda-pixel
Copy link
Contributor

@zunda-pixel zunda-pixel commented Oct 15, 2024

Description

Replace to HTTPTypes's Components.

  1. Helpers.HTTPRequest -> (request: HTTPRequest, bodyData: Data?)
  2. Helpers.HTTPResponse -> (Data, HTTPTypes.HTTPResponse)
  3. headers: [String: String] -> HTTPTypes.HTTPFields

@grdsdev
Copy link
Collaborator

grdsdev commented Oct 15, 2024

Thanks for taking the leap on this @zunda-pixel.

We're not in the stage on having breaking changes at the moment, I'm planning a v3 for next couple of months, breaking changes will have to wait until then. For now, we need to make sure changes are retro-compatible.

@grdsdev grdsdev linked an issue Oct 15, 2024 that may be closed by this pull request
@zunda-pixel
Copy link
Contributor Author

zunda-pixel commented Oct 16, 2024

Ok, I am looking forward to v3.
Supabase v3 is based release/v3 branch?

@grdsdev
Copy link
Collaborator

grdsdev commented Oct 16, 2024

Yes @zunda-pixel , that is the branch.

There are basically 3 issues that I want to fix yet on v2 before I move focus to v3, they are these ones: https://github.com/supabase/supabase-swift/issues?q=is%3Aopen+is%3Aissue+milestone%3Av2

@grdsdev grdsdev added this to the v3 milestone Oct 16, 2024
@zunda-pixel zunda-pixel marked this pull request as draft October 23, 2024 16:25
@zunda-pixel zunda-pixel marked this pull request as ready for review November 30, 2024 12:22
# Conflicts:
#	Sources/Realtime/V2/Types.swift
#	Sources/Supabase/SupabaseClient.swift
#	Tests/IntegrationTests/Postgrest/PostgrestFilterTests.swift
# Conflicts:
#	Sources/Auth/AuthClient.swift
#	Tests/AuthTests/RequestsTests.swift
#	Tests/AuthTests/__Snapshots__/RequestsTests/test#WithPhoneAndPassword.1.txt
# Conflicts:
#	Package.swift
#	Sources/Realtime/V2/RealtimeChannelV2.swift
#	Tests/IntegrationTests/RealtimeIntegrationTests.swift
#	Tests/RealtimeTests/MockWebSocketClient.swift
#	Tests/RealtimeTests/RealtimeTests.swift
#	Tests/RealtimeTests/_PushTests.swift
@zunda-pixel zunda-pixel marked this pull request as draft February 26, 2025 14:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt HTTPRequest and HTTPResponse type from swift-http-types
2 participants