Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Convert all functional components to class components #3

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sweep-nightly[bot]
Copy link

@sweep-nightly sweep-nightly bot commented Jul 19, 2023

Description

This PR converts all functional components in the codebase to class components.

Changes Made

  • Converted functional components to class components in App.js and ClassProperties.js
  • Updated testing examples and instructions in running-tests.md to reflect the changes
  • Modified createReactApp.js and init.js to create and initialize class components by default

Checklist

  • All functional components have been converted to class components
  • Testing examples and instructions have been updated
  • App creation and initialization now use class components by default

Related Issues

Resolves #1

Fixes #1.

To checkout this PR branch, run the following command in your terminal:

git checkout sweep/convert-functional-to-class-components

Copy link
Author

@sweep-nightly sweep-nightly bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! There's just a small issue that needs to be addressed:

  • In the file docusaurus/docs/running-tests.md, you've added a new class component App in the test file but the JSX to be returned in the render method is missing. This will cause a syntax error. Please add the JSX that should be returned in the render method. You can find this on lines 77-85.

Keep up the good work!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sweep: Turn all functional components into class components
0 participants