remove platforms from ResolvedPackage

[tomerd]

motivation: the call sites that use package level platforms are incorrect and can be removed or updated to use product level

changes:

• remove use of package level platforms from PIF generator
• update build plan to use product level platforms
• adjust tests

[tomerd]

@neonichu

[tomerd]

@neonichu this has a dedicated test - need to make sure we can drop it

[abertelrud]

This looks good to me, but would want to hear @neonichu's opinion as well. The target settings override the project settings, so the important thing is that each target sets the right values, as seems to be the case. So I think the dedicated test case you reference can be removed as well.

[neonichu]

I think we have to make more changes to PIFBuilder and its tests. We should add assertion for the various deployment targets at the target level to the tests and set both deployment targets as well as SPECIALIZATION_SDK_OPTIONS. As far as I can see, only test targets are getting a deployment target set after the changes (https://github.com/apple/swift-package-manager/blob/main/Sources/XCBuildSupport/PIFBuilder.swift#L415-L421) but no other target types.

[abertelrud]

I think we have to make more changes to PIFBuilder and its tests. We should add assertion for the various deployment targets at the target level to the tests and set both deployment targets as well as SPECIALIZATION_SDK_OPTIONS. As far as I can see, only test targets are getting a deployment target set after the changes (https://github.com/apple/swift-package-manager/blob/main/Sources/XCBuildSupport/PIFBuilder.swift#L415-L421) but no other target types.

Would it be worth also making sure this case is covered by an end-to-end functional test? It would have to be macOS-only since it relies on xcbuild, but doing the build and then using otool to check what deployment target ended up getting set in the binary seems like the ultimate check whether this works as intended. Otherwise the code could still be doing the "wrong thing" even if the unit test that checks the PIF contents is made to pass.

[tomerd]

@swift-ci smoke test

[tomerd]

@neonichu looks like this is causing some failures on the integration tests when using --build-system = xcode. can you confirm the PIF changes here?