Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PackagePlugin: make Path a wrapper around AbsolutePath #5817

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

compnerd
Copy link
Member

This should help the path representation be properly represented on different platforms. This is motivated by Windows which would have the drive stripped from the path, converting to a relative path the absolute path.

This should help the path representation be properly represented on
different platforms.  This is motivated by Windows which would have
the drive stripped from the path, converting to a relative path the
absolute path.
@compnerd
Copy link
Member Author

@swift-ci please smoke test

@tomerd
Copy link
Contributor

tomerd commented Oct 17, 2022

@abertelrud

@tomerd tomerd added the WIP Work in progress label Oct 17, 2022
Copy link
Contributor

@stevapple stevapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see it, but why not use FilePath instead? That should be more performant and robust, and by using System instead we’re a step closer to the goal of eliminating TSC.

@compnerd
Copy link
Member Author

Because that still needs to be tested more heavily before it can be ready to use. There are issues that have been fixed in t-s-c that haven't been done in System yet. Furthermore, that adds another dependency before this is really ready to be removed. Since this is @_implementationOnly we can swap it later without it impacting the user. I'd say that this makes it no more difficult to remove the t-s-c dependency.

@tomerd tomerd added the windows label Nov 14, 2022
@abertelrud
Copy link
Contributor

Seems reasonable though it's a bit concerning if FilePath still isn't ready for use. @compnerd any idea on when that might be fixed?

@tomerd
Copy link
Contributor

tomerd commented May 1, 2023

@swift-ci smoke test

@MaxDesiatov
Copy link
Contributor

Seems reasonable though it's a bit concerning if FilePath still isn't ready for use. @compnerd any idea on when that might be fixed?

+1 on this, what are the issues on the System repository to track feature parity of FilePath with AbsolutePath?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
windows WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants