-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
PackagePlugin: make Path
a wrapper around AbsolutePath
#5817
base: main
Are you sure you want to change the base?
Conversation
This should help the path representation be properly represented on different platforms. This is motivated by Windows which would have the drive stripped from the path, converting to a relative path the absolute path.
@swift-ci please smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see it, but why not use FilePath
instead? That should be more performant and robust, and by using System instead we’re a step closer to the goal of eliminating TSC.
Because that still needs to be tested more heavily before it can be ready to use. There are issues that have been fixed in t-s-c that haven't been done in System yet. Furthermore, that adds another dependency before this is really ready to be removed. Since this is |
Seems reasonable though it's a bit concerning if FilePath still isn't ready for use. @compnerd any idea on when that might be fixed? |
@swift-ci smoke test |
+1 on this, what are the issues on the System repository to track feature parity of |
This should help the path representation be properly represented on different platforms. This is motivated by Windows which would have the drive stripped from the path, converting to a relative path the absolute path.