[Traits] Support traits in swift package edit and swift package unedit commands
#8417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add entrypoint for trait options in the edit/unedit
commands
TODO:
- Determine how calls to resolve affect packages in edit mode
- If a dependency is guarded by traits in the current workspace,
can we run an edit command on it?
- If we edit a dependency and modify its trait configurations
for its dependencies, how does the resulting resolution
change?
- Add test coverage for edit/unedit cases with trait configurations
- Add test coverage for edit/unedit cases with nested deps that
are guarded by traits + how that changes with edit/unedit
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Fixes #8354
Motivation:
Since the
editanduneditcommands can affect dependency resolution, we must support the ability to specify trait configurations.Modifications:
Result:
TODO: