-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add swift package add-target-plugin
command
#8432
base: main
Are you sure you want to change the base?
Conversation
@swift-ci please test |
@swift-ci please test self hosted windows |
@swift-ci please test windows |
swift package add-target-plugin
command
31f2020
to
d0fe9a8
Compare
@dschaefer2 @bkhouri just want to bump this, I rebased the new changes. |
@swift-ci please test self hosted windows |
@swift-ci please test |
@swift-ci test self hosted windows |
1 similar comment
@swift-ci test self hosted windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could I ask that we add a bit more automated tests?
let contents: String = try fs.readFileContents(manifest) | ||
|
||
XCTAssertMatch(contents, .contains(#".plugin(name: "other-product"#)) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: I really appreciate the automated tests to validate the behaviour we want. Could I trouble you to add a few more that would check different use cases and fault injections?
- Calling
add-target-plugin
on a non-existing package - Calling
add-target-plugin
providing all four combination of a valid/invalid plugin name and target name.
Adds
swift package add-target-plugin
command for adding plugins to target from CLIMotivation:
Featured requested in #8169
Allows users to add package plugins to targets via command line.
Forums Discussion
Modifications:
Add new
add-target-plugin
command which aligns with the existingadd-target-dependency
commandResult:
After running the following command:
The following addition will be made to the
Package.swift
manifest: