Fix swift package describe for packages with binary artifacts that has a .zip extension.

[taji-taji]

Fix swift package describe for packages with binary artifacts that has a .zip extension.

Motivation:

Fixes #4387

I want to avoid an error when running swift package describe on a package that contains a binary artifact target with a .zip extension.

Modifications:

I modified the Workspace.loadRootPackage(at:observabilityScope:completion) method. Specifically, I updated the logic for local binary targets to also return a BinaryArtifact object when the file extension is .zip.
This change is also based on the comment referenced here.

Result:

When running swift package describe on a package that contains a binary artifact target with a .zip extension, the package description is now output without throwing an error.

[plemarquand]

@swift-ci please test

[bkhouri]

Thanks for this change. would it be possible to add a test that ensures we don't accidentally re-introduce this issue?

[taji-taji]

@bkhouri
Thank you for the feedback.
I have modified the contents of testLoadRootPackageWithBinaryDependencies to include a case where a local .zip binary file exists.
I have confirmed that applying this test to the main branch (which does not include the changes from this PR) reproduces the issue and fails as expected.

8777cd9

Test results on the main branch

Test Suite 'Selected tests' started at 2025-06-24 19:27:23.749.
Test Suite 'SwiftPMPackageTests.xctest' started at 2025-06-24 19:27:23.750.
Test Suite 'WorkspaceTests' started at 2025-06-24 19:27:23.750.
Test Case '-[WorkspaceTests.WorkspaceTests testLoadRootPackageWithBinaryDependencies]' started.
/Users/yutaka/workspace/swift-package-manager/Sources/Workspace/Workspace.swift:1138: error: -[WorkspaceTests.WorkspaceTests testLoadRootPackageWithBinaryDependencies] : failed: caught error: "/tmp/ws/roots/Root/a4.zip does not contain binary artifact"
Test Case '-[WorkspaceTests.WorkspaceTests testLoadRootPackageWithBinaryDependencies]' failed (0.199 seconds).
Test Suite 'WorkspaceTests' failed at 2025-06-24 19:27:23.949.
	 Executed 1 test, with 1 failure (1 unexpected) in 0.199 (0.199) seconds
Test Suite 'SwiftPMPackageTests.xctest' failed at 2025-06-24 19:27:23.949.
	 Executed 1 test, with 1 failure (1 unexpected) in 0.199 (0.199) seconds
Test Suite 'Selected tests' failed at 2025-06-24 19:27:23.949.
	 Executed 1 test, with 1 failure (1 unexpected) in 0.199 (0.200) seconds

Test results on this branch

Test Suite 'Selected tests' started at 2025-06-24 19:58:23.823.
Test Suite 'SwiftPMPackageTests.xctest' started at 2025-06-24 19:58:23.824.
Test Suite 'WorkspaceTests' started at 2025-06-24 19:58:23.824.
Test Case '-[WorkspaceTests.WorkspaceTests testLoadRootPackageWithBinaryDependencies]' started.
Test Case '-[WorkspaceTests.WorkspaceTests testLoadRootPackageWithBinaryDependencies]' passed (0.479 seconds).
Test Suite 'WorkspaceTests' passed at 2025-06-24 19:58:24.302.
	 Executed 1 test, with 0 failures (0 unexpected) in 0.479 (0.479) seconds
Test Suite 'SwiftPMPackageTests.xctest' passed at 2025-06-24 19:58:24.302.
	 Executed 1 test, with 0 failures (0 unexpected) in 0.479 (0.479) seconds
Test Suite 'Selected tests' passed at 2025-06-24 19:58:24.302.
	 Executed 1 test, with 0 failures (0 unexpected) in 0.479 (0.480) seconds

[plemarquand]

@swift-ci please test

[bkhouri]

@swift-ci test windows

[taji-taji]

The test Swift Test Windows Platform (self hosted) (Swift 6.1) has failed, but I’m not sure what caused it.
Please let me know if there are any next steps I should take to move this PR forward.

[bkhouri]

@swift-ci test self hosted windows

[taji-taji]

@bkhouri
Thank you for triggering the CI. It looks like all checks have passed, so please continue with the review.

[bkhouri]

This looks good from a test perspective.